faster parachain registration for polkadot-launch tests #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should be sufficient for our testing purposes moonbeam-foundation/polkadot#1 but it's not building locally now :/ |
Contributor
Author
|
Required change made in https://github.com/paritytech/polkadot/pull/2886/files , will close this for now and someone else can bring it back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this for discussion, not for review or to be merged.
There are two approaches to make parachain registration faster for the polkadot-launch tests:
See #311 (comment) for an explanation of (1). I like it because it would make the
ParaLifecycleof the parachains registered at genesisParachainimmediately. The way it works now, we register after genesis and then theParaLifecycleisOnboardingfor 2 sessions. During this time, we cannot open a channel with other parachains which is required for testing XCMP.There is a genesis config for the
paraspallet, but it is not currently exposed in the rococo runtime:So in order to pursue (1), we first need to add
Config<T>there (PR polkadot).